test: fix flaky setGuestName test - #31486
Merged
Merged
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31486 +/- ##
===========================================
- Coverage 49.57% 49.57% -0.01%
===========================================
Files 3316 3316
Lines 81542 81542
Branches 16722 16722
===========================================
- Hits 40425 40421 -4
Misses 36414 36414
- Partials 4703 4707 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
MartinSchoeler
marked this pull request as ready for review
January 18, 2024 14:21
ggazzo
approved these changes
Jan 18, 2024
ggazzo
changed the title
gabriellsh
added a commit
that referenced
this pull request
Jan 19, 2024
…/emailEmoji * 'develop' of github.com:RocketChat/Rocket.Chat: (166 commits) feat: Add `chat.getURLPreview` endpoint (#30478) chore: QoL changes for Omnichannel (#31468) fix: add missing labels to UsersByTimeOfTheDaySection (#31368) refactor: Remove `Notifications` module (#31463) i18n: zh translation error (#21600) feat: `Bubble` on new messages indicators (#31478) test: fix flaky setGuestName test (#31486) Release 6.5.3 chore: RateLimiter to async (#31480) chore: Revert "chore: Add missing changeset file" (#31481) chore: Remove `MessageContentBody` additional styles (#31476) chore: Replace `Notifications` module in favor of `SDK` inside CachedCollection (#31424) chore: improve backend startup (#31479) chore: fix embedded livechat tests (#31477) fix: Department name being double escaped (#31454) chore: Remove unnecessary changeset file (#31472) chore(eslint-config): Include missing ESLint configuration for React (#30977) refactor: Replace `Notifications` module in favor of `sdk` for Omnichannel/WebRTC (#31460) refactor: Replace `Notifications` module in favor of `sdk` for Video Conf (#31462) feat: Add support to cancel editing message action (#31347) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments